[Prism54-devel] Prism54 kernel patches accepted

Margit Schubert-While margitsw at t-online.de
Fri Jun 11 11:04:35 UTC 2004


Aurelien scribeth :
 > Why convert dev_kfree_skb(_irq) to dev_kfree_skb_any ?
 > dev_kfree_skb and dev_kfree_skb_irq are used in the right context. AFAIR

Are you sure ? What about islpci_eth_transmit in islpci_eth.c.
AFAIK this is called in interrupt context or ?
Anyway this will always be right and is tightly coded in the skb routines, so
it only costs a couple of extra instructions.

Which reminds me, there is a missing error check at line 157 where
we allocate a new skb to newskb.

Margit 




More information about the Prism54-devel mailing list