[Prism54-devel] Prism kernel help text and other nitpicks

[Margit Schubert-While]

Hi Luis,
         Current part of help text :

+         If you enable this you will need a firmware file as well. You will
+         need to put this into /usr/lib/hotplug/firmware/isl3890. You can 
get these
+         non-GPL'd firmware files from the Prism54 project page:
+         <http://prism54.org> (in debian it's the package <hotplug> ;). Make
+         sure the package your using comes with firmware.agent too (debian 
unstable
+         package has it ;)


         Suggested change for neutrality and correctness:

+         If you enable this you will need a firmware file as well.
+         You will need to put this into /usr/lib/hotplug/firmware/isl3890.
+         You can get this non-GPL'd firmware file from the Prism54 project 
page:
+         <http://prism54.org>.
+         You will also need the /etc/hotplug/firmware.agent script from
+         a current hotplug package.



+         will be called prism54.o.

         Not for 2.6 !!



         Current part of Config.in for 2.4:

+if [ "$CONFIG_HOTPLUG" = "y" -o "$CONFIG_HOTPLUG" = "m" ]; then
+if [ "$CONFIG_PCMCIA" != "n" -o "$CONFIG_PCI" != "n" ]; then
+   comment 'Prism54 Driver - 802.11(a/b/g)'
+   tristate 'Intersil Prism GT/Duette/Indigo PCI/PCMCIA' CONFIG_PRISM54 \
         $CONFIG_EXPERIMENTAL $CONFIG_PCI $CONFIG_HOTPLUG $CONFIG_FW_LOADER
+if [ "$CONFIG_PRISM54" = "y" -o "$CONFIG_PRISM54" = "m" ]; then
+define_tristate CONFIG_FW_LOADER m
+fi
+fi
+fi

         Suggested mod - replace the whole above with 2 lines (2nd line 
split because of mailer):

comment 'Prism54 Driver - 802.11(a/b/g)'
dep_tristate 'Intersil Prism GT/Duette PCI/PCMCIA' CONFIG_PRISM54 \
   $CONFIG_EXPERIMENTAL $CONFIG_PCI $CONFIG_HOTPLUG $CONFIG_FW_LOADER

         Notes - Firstly the original "tristate" is not correct - 
"tristate" only has 2 parameters.
         "dep_tristate" will check the dependencies on the 3rd and 
successive parameters.
         Secondly, there is no need to check PCMCIA as cardbus support 
depends on PCI.

         Interestingly enough, Firmware Loading depends on CONFIG_HOTPLUG 
which I ithink
         is an error for a PCI only box. Will post a Q to LKML. If true, 
then we can get rid of the
         CONFIG_HOTPLUG dependecy.

         Cheers

         Margit