[Prism54-devel] [PATCH] double-free in isl_ioctl.c

[Aurelien]

hello,
I don't think I changed this behavior... As far as I remember, we have always done it this way. I think that's hvr who introduced it, after rewriting some islpci_mgt.c code. I assumed he knew what he was doing...

Moreover, my commit from 2003/12/29 00:52:45 was not related to this. 
You're probalby speaking of Wed Dec 31 16:22:34 2003 UTC.

...And justice for all

On Tue, 06 Jan 2004 23:02:15 +0100
Jens Maurer <Jens.Maurer@gmx.net> wrote:

> Hello!
> 
> The change on 2003/12/29 00:52:45 by ajfa introduced a
> double-free problem that wreaked havoc with the queues.
> 
> The attached patch restores the old behaviour, i.e.
> we only free the entry if the operation failed and
> we're going to return -EINVAL.
> 
> This problem could have overshadowed the SMC fixes, so
> anyone still having problems with SMC might want to
> give the attached patch a try.
> 
> Jens Maurer
>