[Prism54-devel] [PATCH] double-free in isl_ioctl.c

[Luis R. Rodriguez]

Just as FYI,

The previous change to ajfa's was mine and that's the ChangeLog entry
corresponding to the supposedly SMC-fix. Unfortunately it didn't really
fix anything though :( and I was meaning to delete my ChangeLog entry
since it didn't really fix anything (since what I failed to notice was
that mgt_response will make _rvalue true regardless). The code could
remain though since its harmless (only useful if mgt_response was not
returning the correct value).

I thought the changes I made fixed the problems with the SMC card but
unfortunately it was just purely coincidence that after some testing I
was doing it started working. Great huh :-D yeah -- the card I'm working
with just randomly likes to work and then stop working (at init time).

	Luis

On Tue, 6 Jan 2004, Jens Maurer wrote:

> Hello!
>
> The change on 2003/12/29 00:52:45 by ajfa introduced a
> double-free problem that wreaked havoc with the queues.
>
> The attached patch restores the old behaviour, i.e.
> we only free the entry if the operation failed and
> we're going to return -EINVAL.
>
> This problem could have overshadowed the SMC fixes, so
> anyone still having problems with SMC might want to
> give the attached patch a try.
>
> Jens Maurer
>