[Prism54-devel] Re: [Prism54-users] Output power regulation - SMC2802W

[Luis R. Rodriguez]

--jL2BoiuKMElzg3CS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


This has been committed. Thanks,

	Luis

On Wed, Feb 18, 2004 at 11:38:45PM +0100, Feyd wrote:
> On Wed, 7 Jan 2004 11:12:42 +0100
> Aurelien <slts@free.fr> wrote:
>=20
> > =20
> > > > 3) How does it behaves with negative values ?
> > > ???
> > > What do you mean negative values ??? How strangth can be negative ?
> > > And as I already mentioned - you cannot set value bigger than 127, so
> > > there's no negative value.
> >=20
> > Well, a power in dBm can be negative. And when I tried your patch, I wa=
s able
> > to set the oid to some negative value.
>=20
> The attached patch fixes negative value setting.
>=20
> > > If you're using prism54 card in client mode - its useless, 'cause afa=
ik=20
> > > cards sets output power according to AP output power ( correct me, if
> > > I'm wrong).
>=20
> It seems to work in client mode as well, lowering the value the connection
> to a distant AP becomes worse.
>=20
> Feyd

> diff -urNd prism54-cvs-latest-orig/ksrc/isl_ioctl.c prism54-cvs-latest/ks=
rc/isl_ioctl.c
> --- prism54-cvs-latest-orig/ksrc/isl_ioctl.c	2004-02-04 17:30:13.00000000=
0 +0100
> +++ prism54-cvs-latest/ksrc/isl_ioctl.c	2004-02-18 21:44:09.000000000 +01=
00
> @@ -1182,7 +1182,7 @@
> =20
>  	rvalue =3D mgt_get_request(priv, OID_INL_OUTPUTPOWER, 0, NULL, &r);
>  	/* intersil firmware operates in 0.25 dBm (1/4 dBm) */
> -	vwrq->value =3D r.u / 4;
> +	vwrq->value =3D (s32)r.u / 4;
>  	vwrq->fixed =3D 1;
>  	/* radio is not turned of
>  	 * btw: how is possible to turn off only the radio=20
> @@ -1197,7 +1197,7 @@
>  		    struct iw_param *vwrq, char *extra)
>  {
>  	islpci_private *priv =3D ndev->priv;
> -	u32 u =3D vwrq->value;
> +	s32 u =3D vwrq->value;
> =20
>  	/* intersil firmware operates in 0.25 dBm (1/4) */
>  	u *=3D 4;


--=20
Key fingerprint =3D 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E

--jL2BoiuKMElzg3CS
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFANYHyat1JN+IKUl4RAj9JAJ41asaRM7Mh20eamFuWHYbfPUlhFgCfS1Qm
OKqYbFkdflCvXrThD9YZjOk=
=tdza
-----END PGP SIGNATURE-----

--jL2BoiuKMElzg3CS--