[Prism54-devel] Re: [Prism54-users] Output power regulation - SMC2802W

[Feyd]

This is a multi-part message in MIME format.

--Multipart=_Wed__18_Feb_2004_23_38_45_+0100_HV9VtVg_x=ktkvy/
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 7 Jan 2004 11:12:42 +0100
Aurelien <slts@free.fr> wrote:

>  
> > > 3) How does it behaves with negative values ?
> > ???
> > What do you mean negative values ??? How strangth can be negative ?
> > And as I already mentioned - you cannot set value bigger than 127, so
> > there's no negative value.
> 
> Well, a power in dBm can be negative. And when I tried your patch, I was able
> to set the oid to some negative value.

The attached patch fixes negative value setting.

> > If you're using prism54 card in client mode - its useless, 'cause afaik 
> > cards sets output power according to AP output power ( correct me, if
> > I'm wrong).

It seems to work in client mode as well, lowering the value the connection
to a distant AP becomes worse.

Feyd

--Multipart=_Wed__18_Feb_2004_23_38_45_+0100_HV9VtVg_x=ktkvy/
Content-Type: text/plain;
 name="subzero.diff"
Content-Disposition: attachment;
 filename="subzero.diff"
Content-Transfer-Encoding: 7bit

diff -urNd prism54-cvs-latest-orig/ksrc/isl_ioctl.c prism54-cvs-latest/ksrc/isl_ioctl.c
--- prism54-cvs-latest-orig/ksrc/isl_ioctl.c	2004-02-04 17:30:13.000000000 +0100
+++ prism54-cvs-latest/ksrc/isl_ioctl.c	2004-02-18 21:44:09.000000000 +0100
@@ -1182,7 +1182,7 @@
 
 	rvalue = mgt_get_request(priv, OID_INL_OUTPUTPOWER, 0, NULL, &r);
 	/* intersil firmware operates in 0.25 dBm (1/4 dBm) */
-	vwrq->value = r.u / 4;
+	vwrq->value = (s32)r.u / 4;
 	vwrq->fixed = 1;
 	/* radio is not turned of
 	 * btw: how is possible to turn off only the radio 
@@ -1197,7 +1197,7 @@
 		    struct iw_param *vwrq, char *extra)
 {
 	islpci_private *priv = ndev->priv;
-	u32 u = vwrq->value;
+	s32 u = vwrq->value;
 
 	/* intersil firmware operates in 0.25 dBm (1/4) */
 	u *= 4;

--Multipart=_Wed__18_Feb_2004_23_38_45_+0100_HV9VtVg_x=ktkvy/--