[Prism54-devel] Recent changes to reset functionality

[Luis R. Rodriguez]

Oh yea, feel free to take care of this too if you get around to it
before I do 8)

	Luis

On Mon, Feb 09, 2004 at 02:38:42PM -0500, Luis R. Rodriguez wrote:
> 
> I'll take care of this, thanks.
> 	Luis
> 
> On Sat, Feb 07, 2004 at 06:04:10PM +0100, Jens Maurer wrote:
> > 
> > I've had a look at islpci_reset_if() and
> > the function that calls it, islpci_reset().
> > 
> > I think the general approach is fine (give the card a little
> > more time if the interrupt doesn't come through the
> > first time), but the implementation has a race condition.
> > There is a time window between leaving islpci_reset_if() the
> > first time and re-entering it later where a reset interrupt
> > would not trigger the wait queue, because no interested
> > parties are registered at this moment.
> > 
> > I suggest moving the "wait a little longer" functionality
> > entirely into islpci_reset_if(), and make sure to continue
> > to perform adequate waitqueue maintenance there.
> > 
> > Jens Maurer
> > 
> > _______________________________________________
> > Prism54-devel mailing list
> > Prism54-devel@prism54.org
> > http://prism54.org/mailman/listinfo/prism54-devel
> _______________________________________________
> Prism54-devel mailing list
> Prism54-devel@prism54.org
> http://prism54.org/mailman/listinfo/prism54-devel