[Prism54-devel] handle mgmt timeouts by resetting hardware
Denis Vlasenko
vda at port.imtp.ilyichevsk.odessa.ua
Tue Aug 3 14:34:09 UTC 2004
On Tuesday 03 August 2004 15:22, Margit Schubert-While wrote:
> Mike scribeth :
> > I get a panic with my WG511 when I insert the card ..
>
> Not surprising -
>
> Denis scribeth :
> > * Superfluous NULLs killed. Not needed since islpci_mgt_transaction()
> > sets response to NULL as a first step.
>
> Not true !!
> Synopsis:
> islpci_mgt_transaction is only called if the card is ready in
> mgt_get_request. In Mike's case, the card is not ready.
> With (cache) as true, (therefore ret = 0), we later do :
> if (response && !ret)
> islpci_mgt_release(response);
Oh. I've got an oops too. I tracked it to my changes :(.
I wasn't careful enough and didn't notice that
in two places islpci_mgt_transaction() can be bypassed.
OTOH, in prism54_debug_get/set_oid, NULL removal is valid.
I am resubmiting corrected patch against today's CVS.
Run tested. Please apply.
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reset54.patch
Type: text/x-diff
Size: 23144 bytes
Desc: not available
Url : http://prism54.org/pipermail/prism54-devel/attachments/20040803/877159cb/reset54-0001.bin
More information about the Prism54-devel
mailing list