[Prism54-devel] Load firmware @ probe

[Luis R. Rodriguez]

--UPT3ojh+0CqEDtpF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


Actually,

if this patch is applied, as is, it will load the firmware @ probe time
and then if you forgot to install hotplug, download the firmware, etc
you can just do that afterwards (even if the driver was built in) and
then just ifconfig eth0 up the device when the firmware is ready.

The only downside I can think of of loading the firwmare @ probe is that
the radio is turned *on*, which I do not think is necessarily a bad
thing.

	Luis

On Fri, Apr 16, 2004 at 06:58:59PM -0400, Luis R. Rodriguez wrote:
>=20
> OK, I'm stubborn, what can I say. I'd personally would prefer the driver
> load the firmware @ probe time. Attached patch does this. This also
> allows for the re-loading of the firmware @ open time. We previously
> hadn't done this because -- what if the driver was built-in. But you
> know what -- if you have the driver built-in right now you're still
> screwed if you don't have the firmware available @ bootup.
>=20
> Before I make this change I'd just like to ask *again* for comments in
> favor/against enabling this behaviour.
>=20
> 	Luis
>=20
> --=20
> GnuPG Key fingerprint =3D 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 5=
25E

> diff -Naur prism54-cvs-latest/ksrc/islpci_hotplug.c prism54-cvs-latest-mc=
grof/ksrc/islpci_hotplug.c
> --- prism54-cvs-latest/ksrc/islpci_hotplug.c	2004-03-20 11:58:36.00000000=
0 -0500
> +++ prism54-cvs-latest-mcgrof/ksrc/islpci_hotplug.c	2004-04-14 19:01:52.0=
00000000 -0400
> @@ -299,6 +299,7 @@
> =20
>  	/* Pretty card model discovery output */
>  	prism54_get_card_model(ndev);
> +	islpci_reset(priv, 1);
> =20
>  	return 0;
> =20




--=20
GnuPG Key fingerprint =3D 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E

--UPT3ojh+0CqEDtpF
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAgHSxat1JN+IKUl4RArFbAJ0fOxVNTqVM4k3GbBoKsIiIgCWMMgCgj7Ur
guzNDfqYmr5MGNkPZgicFGA=
=D5OM
-----END PGP SIGNATURE-----

--UPT3ojh+0CqEDtpF--