[Prism54-devel] Load firmware @ probe

Luis R. Rodriguez mcgrof@ruslug.rutgers.edu
Fri, 16 Apr 2004 18:58:59 -0400


--8P1HSweYDcXXzwPJ
Content-Type: multipart/mixed; boundary="GvXjxJ+pjyke8COw"
Content-Disposition: inline


--GvXjxJ+pjyke8COw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


OK, I'm stubborn, what can I say. I'd personally would prefer the driver
load the firmware @ probe time. Attached patch does this. This also
allows for the re-loading of the firmware @ open time. We previously
hadn't done this because -- what if the driver was built-in. But you
know what -- if you have the driver built-in right now you're still
screwed if you don't have the firmware available @ bootup.

Before I make this change I'd just like to ask *again* for comments in
favor/against enabling this behaviour.

	Luis

--=20
GnuPG Key fingerprint =3D 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E

--GvXjxJ+pjyke8COw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="auto_load.diff"
Content-Transfer-Encoding: quoted-printable

diff -Naur prism54-cvs-latest/ksrc/islpci_hotplug.c prism54-cvs-latest-mcgr=
of/ksrc/islpci_hotplug.c
--- prism54-cvs-latest/ksrc/islpci_hotplug.c	2004-03-20 11:58:36.000000000 =
-0500
+++ prism54-cvs-latest-mcgrof/ksrc/islpci_hotplug.c	2004-04-14 19:01:52.000=
000000 -0400
@@ -299,6 +299,7 @@
=20
 	/* Pretty card model discovery output */
 	prism54_get_card_model(ndev);
+	islpci_reset(priv, 1);
=20
 	return 0;
=20

--GvXjxJ+pjyke8COw--

--8P1HSweYDcXXzwPJ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAgGUzat1JN+IKUl4RAlJDAJ9S5n8TyHtREyb5f6XjzpbPKa3cwwCglz7a
6QDDb1mMBIgi8ap7NRXrdKA=
=HH6t
-----END PGP SIGNATURE-----

--8P1HSweYDcXXzwPJ--