[Prism54-devel] Re: Problems with a PCI SMC2802W

[Luis R. Rodriguez]

Jeff/netdev,

If no comment is given on how we should deal with
pci_dma_sync_single/pci_dma_sync_single_for_cpu for 2.4 I'm just going
to put in a nasty ifdef there. Comemnts?

	Luis

On Thu, Mar 10, 2005 at 11:30:07AM -0500, Luis R. Rodriguez wrote:
> > Index: ksrc/islpci_mgt.c
> > ===================================================================
> > --- ksrc/islpci_mgt.c	(revision 528)
> > +++ ksrc/islpci_mgt.c	(working copy)
> > @@ -345,7 +345,7 @@
> >  		}
> >  
> >  		/* Ensure the results of device DMA are visible to the CPU. */
> > -		pci_dma_sync_single(priv->pdev, buf->pci_addr,
> > +		pci_dma_sync_single_for_cpu(priv->pdev, buf->pci_addr,
> >  				frag_len, PCI_DMA_FROMDEVICE);
> >  
> >  		/* Perform endianess conversion for PIMFOR header in-place. */
> 
> Thanks, but the pci_[restore|save]_state changes requires testing/backporting to 2.4. 
> Same goes for pci_dma_sync_single_for_cpu(). We can macro this but ugh, it's just so 
> horrible.
> 
> Margit, where are you?
> 
> Jeff, what's better a prismcompat24.h edit or a check for
> LINUX_VERSION_CODE here?
> 
> 	Luis
> 
> -- 
> GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E



-- 
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://prism54.org/pipermail/prism54-devel/attachments/20050316/b9d7aa93/attachment.pgp