[Prism54-devel] [mcgrof@ruslug.rutgers.edu: Re: [patch 1/3] net/islpci_dev: replace schedule_timeout() with msleep()]

[Luis R. Rodriguez]

----- Forwarded message from "Luis R. Rodriguez" <mcgrof at ruslug.rutgers.edu> -----

To: domen at coderock.org
Cc: prism54-private at prism54.org, netdev at oss.sgi.com, nacc at us.ibm.com,
	janitor at sternwelten.at
Subject: Re: [patch 1/3] net/islpci_dev: replace schedule_timeout() with msleep()
Mail-Followup-To: domen at coderock.org, prism54-private at prism54.org,
	netdev at oss.sgi.com, nacc at us.ibm.com, janitor at sternwelten.at
X-Operating-System: 2.4.18-1-686
Organization: Rutgers University Student Linux Users Group
From: mcgrof at ruslug.rutgers.edu (Luis R. Rodriguez)


Patch applied to prism54 latest svn tree, thanks

	Luis

On Sun, Mar 06, 2005 at 11:23:51PM +0100, domen at coderock.org wrote:
> 
> 
> 
> 
> Use msleep() instead of schedule_timeout()
> to guarantee the task delays as expected. Also set_current_state() is
> inserted before schedule_timeout().
> 
> Signed-off-by: Nishanth Aravamudan <nacc at us.ibm.com>
> Signed-off-by: Maximilian Attems <janitor at sternwelten.at>
> Signed-off-by: Domen Puncer <domen at coderock.org>
> ---
> 
> 
>  kj-domen/drivers/net/wireless/prism54/islpci_dev.c |    3 +--
>  1 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff -puN drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev drivers/net/wireless/prism54/islpci_dev.c
> --- kj/drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev	2005-03-05 16:09:30.000000000 +0100
> +++ kj-domen/drivers/net/wireless/prism54/islpci_dev.c	2005-03-05 16:09:30.000000000 +0100
> @@ -438,8 +438,7 @@ prism54_bring_down(islpci_private *priv)
>  	wmb();
>  
>  	/* wait a while for the device to reset */
> -	set_current_state(TASK_UNINTERRUPTIBLE);
> -	schedule_timeout(50*HZ/1000);
> +	msleep(50);
>  
>  	return 0;
>  }
> _

-- 
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E



----- End forwarded message -----

-- 
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E