[Prism54-devel] Re: 2.6.9-mm1: pc_debug multiple definitions

[Luis R. Rodriguez]

On Fri, Oct 22, 2004 at 03:39:29PM +0200, Adrian Bunk wrote:
> 
> The following compile error comes from Linus' tree:
> 
> 
> <--  snip  -->
> 
> ...
>   LD      drivers/built-in.o
> drivers/pcmcia/built-in.o(.bss+0xf20): multiple definition of `pc_debug'
> drivers/net/built-in.o(.data+0x24ae0): first defined here
> make[1]: *** [drivers/built-in.o] Error 1
> 
> <--  snip  -->
> 
> 
> The pc_debug in drivers/pcmcia/ds.c was made non-static in Linus' tree,
> but the global definition of a global variable with such a generic name 
> in drivers/net/wireless/prism54/islpci_mgt.c seems to be equally wrong.

Great, anyone know why this change was done on ds.c ? The pc_debug on
prism54 comes from the original Intersil driver. It is used to for
debugging but we should move away from our current debugging mechanism
to netif_msg.

Margit, do you have some pending commits left? Do you want to take a
stab at this? If not I can later on this week.

	Luis

-- 
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E