[Prism54-devel] Re: Add depmod to Makefile

[Pavel Roskin]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-358222530-1085097722=:6103
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed

On Wed, 19 May 2004, Margit Schubert-While wrote:

>> Margit will hopefully appreciate that KVER doesn't need to be overridden.
> She does :-)
>
> The correct way to do it is to use version.h
> Some distro's make changes to the default Makefile,

Fixed.  Thank you!  I have already fixed the Makefile in the Orinoco 
driver.

> In version.h, however, we should have the correct name.
> (eg. #define UTS_RELEASE "2.6.4-1-margit")
> Can you put up an amended patch ?

Attached.

> One other nitpick - Can you take out the absolute path for depmod.
> So just "depmod" instead of "/sbin/depmod".

I disagree.  /sbin is not in $PATH for users by default, and the root 
environment inherits $PATH from the user when "su" is used.

> Oh, and incidentally, a good distro will check if a depmod is needed
> as part of the boot process. (admittedly, a little late if anything is wrong)

Agreed.

-- 
Regards,
Pavel Roskin
--8323328-358222530-1085097722=:6103
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="kver_depmod2.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.60.0405202002020.6103@marabou.research.att.com>
Content-Description: 
Content-Disposition: attachment; filename="kver_depmod2.diff"

LS0tIE1ha2VmaWxlDQorKysgTWFrZWZpbGUNCkBAIC0xLDExICsxLDE5IEBA
DQogIyAkSWQ6IE1ha2VmaWxlLHYgMS45IDIwMDQvMDMvMDIgMDA6NTk6MjIg
bWNncm9mIEV4cCAkDQogDQotS1ZFUgkgICAgICAgOj0gJChzaGVsbCB1bmFt
ZSAtcikNCi1LRElSICAgICAgICAgICA6PSAvbGliL21vZHVsZXMvJChLVkVS
KS9idWlsZA0KLUtNSVNDICAgICAgICAgIDo9IC9saWIvbW9kdWxlcy8kKEtW
RVIpL2tlcm5lbC9kcml2ZXJzL25ldC93aXJlbGVzcy9wcmlzbTU0Lw0KLUtF
WFQgICAgICAgICAgIDo9ICQoc2hlbGwgZWNobyAkKEtWRVIpIHwgc2VkIC1u
ZSAncy9eMlwuWzU2N11cLi4qL2svcCcpbw0KKyMgUGF0aCB0byB0aGUga2Vy
bmVsIHNvdXJjZQ0KK0tESVIgICAgICAgICAgIDo9ICQoc2hlbGwgcmVhZGxp
bmsgLWYgL2xpYi9tb2R1bGVzL2B1bmFtZSAtcmAvYnVpbGQpDQorDQorIyBX
aGVyZSB0byBpbnN0YWxsIHRoZSBtb2R1bGVzDQorS01JU0MgICAgICAgICAg
PSAvbGliL21vZHVsZXMvJChLVkVSKS9rZXJuZWwvZHJpdmVycy9uZXQvd2ly
ZWxlc3MvcHJpc201NC8NCisNCisjIE91dHB1dCBkaXJlY3RvcnkgdXNlZCB3
aGVuIGJ1aWxkaW5nIExpbnV4IGtlcm5lbCwgaWYgYW55ICgyLjYga2VybmVs
cykNCiBLT1VUICAgICAgICAgICA6PSAkKEtESVIpDQogDQorIyBZb3Ugc2hv
dWxkIG5vdCBuZWVkIHRvIG92ZXJyaWRlIHZhcmlhYmxlcyBiZWxvdyB0aGlz
IGxpbmUNCitLVkVSICAgICAgICAgICA6PSAkKHNoZWxsIHNlZCAtbmUgJ3Mv
Ii8vZztzL15cI2RlZmluZSBVVFNfUkVMRUFTRSAvL3AnIFwNCisJCSAgICAk
KEtPVVQpL2luY2x1ZGUvbGludXgvdmVyc2lvbi5oKQ0KK0tFWFQgICAgICAg
ICAgIDo9ICQoc2hlbGwgZWNobyAkKEtWRVIpIHwgc2VkIC1uZSAncy9eMlwu
WzU2N11cLi4qL2svcCcpbw0KKw0KIC5QSE9OWTogZGVmYXVsdCBtb2R1bGVz
IGluc3RhbGwgY2xlYW4gbW9kdWxlLWFsbCBtb2R1bGVzLWNsZWFuIG1vZHVs
ZXMtaW5zdGFsbA0KIA0KIGRlZmF1bHQ6IA0KQEAgLTM1LDYgKzQzLDkgQEAN
CiBtb2R1bGVzLWluc3RhbGw6DQogCWluc3RhbGwgLWQgJChLTUlTQykNCiAJ
aW5zdGFsbCAtbSA2NDQgLWMga3NyYy9wcmlzbTU0LiQoS0VYVCkgJChLTUlT
QykNCitpZmVxICgkKEtWRVIpLCAkKHNoZWxsIHVuYW1lIC1yKSkNCisJL3Ni
aW4vZGVwbW9kIC1hZQ0KK2VuZGlmDQogCSNpbnN0YWxsIC1kIC91c3IvbGli
L2hvdHBsdWcvZmlybXdhcmUNCiAJI2luc3RhbGwgLWMgaXNsMzg3NyAvdXNy
L2xpYi9ob3RwbHVnL2Zpcm13YXJlDQogCSNpbnN0YWxsIC1jIGlzbDM4OTAg
L3Vzci9saWIvaG90cGx1Zy9maXJtd2FyZQ0K

--8323328-358222530-1085097722=:6103--