[Prism54-devel] Race in private ioctls

Aurelien slts@free.fr
Fri, 05 Mar 2004 19:12:19 +0100


Hi all,
I have some code in my local tree that does nice oid get/set. I didn't 
have time to better test it, that's why I did not commit it some time 
ago. Now that I have some time, I'm gonna resume my work on it and 
probably commit it soon.

PS : it uses private subioctls.

...And justice for all

Feyd wrote:
> On Sun, 22 Feb 2004 18:04:06 +0200
> Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> wrote:
> 
> 
>>setoid:
>>======
>>#!/bin/sh
>>args=`echo $@ | cut -d" " -f3-`
>>iwpriv $1 oid $2
>>iwpriv $1 set_oid $args
>>
>>This is racy.
> 
> 
> True.
> 
> 
>>I think we need different interface here, like this:
>>
>># iwpriv eth1 gPROFILES
>>eth1      gPROFILES:1
>># iwpriv eth1 sPROFILES 0
>>
>>No races, and referencing OIDs by name and not by number is
>>easier for humans.
>>
>>Is anything wrong with such interface?
> 
> 
> Only 32 private ioctls available, handles only oids known at compile
> time. While regular users will need something more fiendly to controll
> al the fetaures, this is an easy way to discover how each oid works
> for people interested in implemeting new features or tweaking the
> card.
> 
> Feyd
> _______________________________________________
> Prism54-devel mailing list
> Prism54-devel@prism54.org
> http://prism54.org/mailman/listinfo/prism54-devel
> 
>