[Prism54-devel] Comments to hotplug.c

[Margit Schubert-While]

Aurelien scribeth :
 > I might be wrong but AFAIR, SA_INTERRUPT should be used only for very 
short interrupt handler.
 > And I'm not sure it has any effect on x86.
 > Moreover, I think that in intersil code, SA_INTERRUPT was set, but has 
been removed by us (probably HVR ?).
 > In other words, I don't think your change is a good idea...

 >> Myself scribeth :
 >> How about this :
 >> Current :
 >>        /* request for the interrupt before uploading the firmware */
 >>      rvalue = request_irq(pdev->irq, &islpci_interrupt,
 >>                            SA_SHIRQ, ndev->name, priv);
 >> Proposed :
 >>       /* request for the interrupt before uploading the firmware */
 >>      rvalue = request_irq(pdev->irq, &islpci_interrupt,
 >>                            SA_SHIRQ | SA_INTERRUPT, ndev->name, priv);
 >> In other words, disable local interrupts while processing.

I wasn't suggesting applying it, just wanted to know if anybody had any 
ideas on it.
I played around with it and found on UP and SMP (x86), I got increased 
throughput (especially RX ??!)
Weird.

Margit