[Prism54-devel] Kernel patch & Firmware loading

Marcel Holtmann marcel@holtmann.org
22 Jan 2004 19:48:28 +0100


Hi Margit,

>  > However if you plan to submit the driver for kernel inclusion this have 
> to go away.
>          Why ? Many other drivers do the same (ftape, joystick and sound 
> just to mention a few).

of course there are current examples that do it and there are still
drivers that use KERNEL_VERSION to check some particular features. But
when you submit a new driver for kernel inclusion these have to go,
because the subsystems maintainers will have an eye on these stuff. And
this good, because this keeps the drivers in the kernel clean. Remember
that #ifdef's in C files are bad. Try to avoid them where ever possible.

Regards

Marcel