[Prism54-devel] Recent changes to islpci_alloc_memory

[Jens Maurer]

I oppose these changes in islpci_alloc_memory:

* islpci_dev.c (islpci_alloc_memory): if ioremap fails, iounmap it.
If pci_alloc_consistent fails, pci_free_consistent it.

They are unnecessary and potentially dangerous.
For example, if ioremap fails, nothing actually has been mapped,
so we shouldn't iounmap anything.
Similar with pci_alloc_consistent.

I ask to consider reverting this part of the patch.

Jens Maurer