[Prism54-devel] Broken DMA mask check

[Jens Maurer]

This is a multi-part message in MIME format.
--------------000507040105030404020601
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit


Jens Maurer wrote:
> In prism54_probe(), we set the DMA mask of the device.
> The code is completely broken (see below): If the
> original all-ones DMA mask does not work, we try succeedingly
> smaller mask values until one fits.

I've attached a patch that fixes this.  Plus makes the code
shorter and simpler :-)

Jens Maurer


--------------000507040105030404020601
Content-Type: text/plain;
 name="set_dma_mask.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="set_dma_mask.patch"

SW5kZXg6IGlzbHBjaV9ob3RwbHVnLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL3Zhci9s
aWIvY3ZzL3ByaXNtNTQtbmcva3NyYy9pc2xwY2lfaG90cGx1Zy5jLHYKcmV0cmlldmluZyBy
ZXZpc2lvbiAxLjQ3CmRpZmYgLXUgLXUgLXIxLjQ3IGlzbHBjaV9ob3RwbHVnLmMKLS0tIGlz
bHBjaV9ob3RwbHVnLmMJMjYgRGVjIDIwMDMgMTY6MzI6MzEgLTAwMDAJMS40NworKysgaXNs
cGNpX2hvdHBsdWcuYwk0IEphbiAyMDA0IDE4OjM2OjEwIC0wMDAwCkBAIC0xMzQsNyArMTM0
LDYgQEAKIAl1OCBsYXRlbmN5X3RtcjsKIAlpc2xwY2lfcHJpdmF0ZSAqcHJpdjsKIAlpbnQg
cnZhbHVlOwotCWludCBkbWFfbWFzayA9IDB4ZmZmZmZmZmY7CiAKIAkvKiBUUkFDRShEUlZf
TkFNRSk7ICovCiAKQEAgLTE1NSwyMSArMTU0LDEyIEBACiAJCQkJICAgICAgUENJREVWSUNF
X0xBVEVOQ1lfVElNRVJfVkFMKTsKIAl9CiAKLQkvKiBkZXRlcm1pbmUgd2hhdCB0aGUgc3Vw
cG9ydGVkIERNQSBtZW1vcnkgcmVnaW9uIGlzICovCi0Jd2hpbGUgKHBjaV9zZXRfZG1hX21h
c2socGRldiwgZG1hX21hc2spICE9IDApIHsKLQkJLyogcmFuZ2Ugbm90IHN1cHBvcnRlZCwg
c2hpZnQgdGhlIG1hc2sgYW5kIGNoZWNrIGFnYWluICovCi0JCWlmIChkbWFfbWFzayA+Pj0g
MSwgZG1hX21hc2sgPT0gMCkgewotCQkJLyogbWFzayBpcyB6ZXJvLCBETUEgbWVtb3J5IG5v
dCBzdXBwb3J0ZWQgYnkgUENJICovCi0JCQlwcmludGsoS0VSTl9FUlIgIiVzOiBETUEgTWVt
b3J5IG5vdCBzdXBwb3J0ZWRcbiIsCi0JCQkgICAgICAgRFJWX05BTUUpOwotCQkJZ290byBk
b19wY2lfZGlzYWJsZV9kZXZpY2U7Ci0JCX0KKwkvKiBlbmFibGUgUENJIERNQSAqLworCWlm
IChwY2lfc2V0X2RtYV9tYXNrKHBkZXYsIDB4ZmZmZmZmZmYpKSB7CisJCXByaW50ayhLRVJO
X0VSUiAiJXM6IDMyLWJpdCBQQ0kgRE1BIG5vdCBzdXBwb3J0ZWQiLCBEUlZfTkFNRSk7CisJ
CWdvdG8gZG9fcGNpX2Rpc2FibGVfZGV2aWNlOwogCX0KIAotI2lmIFZFUkJPU0UgPiBTSE9X
X0VSUk9SX01FU1NBR0VTCi0JREVCVUcoU0hPV19UUkFDSU5HLCAiRE1BIE1lbW9yeSBzdXBw
b3J0IG1hc2sgaXMgMHgleCBcbiIsIGRtYV9tYXNrKTsKLSNlbmRpZgotCQogCS8qIEkgZGlk
bid0IGZpbmQgaW4gbGludXgvcGNpLmggd2hhdCB0aG9zZSAyIGJ5dGVzIGFyZSBidXQgc2V0
dGluZyB0aGVtCiAJICogbWFrZXMgdGhlIGNhcmQgbW9yZSBzdGFibGUuIERvZXMgaXQgc29s
dmUgdGhlIEFDUEkgIGJ1ZyAgPwogCSAqLwo=
--------------000507040105030404020601--