[Prism54-devel] handling of -EINPROGRESS

[Luis R. Rodriguez]

--1XWsVB21DFCvn2e8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 22, 2004 at 08:43:05PM +0200, Denis Vlasenko wrote:
> I can't locate code which should "Call commit handler".
> I tracked ioctl to wireless.c and dev.c, it seems to me it must
> propagate error code all the way to userspace, but obviosly
> it doesn't...
>=20
> What am I missing here?

I don't remember exactly, but I think that use of -EINPROGRESS came from
modeling our ioctl by what others do. ie, see airo.c airo_set_freq
which sets:

int rc =3D -EINPROGRESS;          /* Call commit handler */

Looking through wireless.c I see call_commit_handler and I see it called
only in ioctl_standard_call:

        if(ret =3D=3D -EIWCOMMIT)
	                ret =3D call_commit_handler(dev);

So perhaps we should be returning EIWCOMMIT instead.

	Luis

--=20
Key fingerprint =3D 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E

--1XWsVB21DFCvn2e8
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAOQqlat1JN+IKUl4RAnYFAJ9+dU+HIgT6TMAPtKwEYj6C6nQqRACfdvV6
tzwUazBGWkag3nJiVsL++jQ=
=E8iq
-----END PGP SIGNATURE-----

--1XWsVB21DFCvn2e8--