[Prism54-devel] Kill a tarball compile if FW not in kernel

[Marcel Holtmann]

Hi Margit,

> Here's the suggested patch diff for isl_38xx.c to kill
> a tarball compile if FW is not in the kernel.
> 
> diff -Naur linux-2.4.24/drivers/net/wireless/prism54/isl_38xx.c 
> linux-2.4.24mod/drivers/net/wireless/prism54/isl_38xx.c
> --- linux-2.4.24/drivers/net/wireless/prism54/isl_38xx.c        2004-02-03 
> 20:37:04.000000000 +0100
> +++ linux-2.4.24mod/drivers/net/wireless/prism54/isl_38xx.c     2004-02-03 
> 22:21:00.000000000 +0100
> @@ -31,6 +31,11 @@
>   #include <asm/uaccess.h>
>   #include <asm/io.h>
> 
> +#include <linux/config.h>
> +#if !defined(CONFIG_FW_LOADER) && !defined(CONFIG_FW_LOADER_MODULE)
> +#error No Firmware Loading configured in the kernel !
> +#endif
> +
>   #include "islpci_dev.h"
>   #include "islpci_mgt.h"

what is CONFIG_FW_LOADER_MODULE?

I am not a friend of such stuff, because it have to be removed before
this driver can be included in the kernel. Once this driver is part of
the kernel you have to decide how you gonna maintain it. Following two
different major kernel versions and an additional outside package can be
a full-time job.

However the README is very clear about the FW_LOADER stuff and if people
don't read it before they start compiling, I can only tell them to RTFM.

Regards

Marcel