[Prism54-devel] Re: Suggested patch for 2.4 builds

[Luis R. Rodriguez]

I actually *really* don't like that we don't select FW_LOADER for the
user if they enable our driver. You told me this behaviour was frowned
upon by other kernel maintainers. Can someone counter this of comment on
it? I prefer we rather autoselect the module for the user, but that's
just me.

	Luis

On Tue, Feb 03, 2004 at 09:38:26AM +0100, Margit Schubert-While wrote:
> OK, we now have the kernel 2.4 patch and the isl_pcidev.h patch
> which is fine for a kernel build. If somebody tries to use it on a kernel
> that doesn't have FW loading, then Prism54 can not be selected.
> But, what about a tarball build ? (yes, ultimately undefined symbols
> and posts to forums/mail lists)
> Let's do this :
> First module to be compiled is isl_38xx
> 
> Insert
> #include <linux.config.h>
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,0)
> #if !defined(CONFIG_FW_LOADER) && !defined(CONFIG_FW_LOADER_MODULE)
> #abort No Firmware Loading configured in the kernel !
> #endif
> #endif
> 
> Which should be plain enough for anybody.
> 
> Margit
>