[Prism54-devel] Recent changes to islpci_alloc_memory

[Luis R. Rodriguez]

On Sat, Jan 31, 2004 at 06:47:10PM +0100, Jens Maurer wrote:

> 
> I oppose these changes in islpci_alloc_memory:
> 
> * islpci_dev.c (islpci_alloc_memory): if ioremap fails, iounmap it.
> If pci_alloc_consistent fails, pci_free_consistent it.
> 
> They are unnecessary and potentially dangerous.
> For example, if ioremap fails, nothing actually has been mapped,
> so we shouldn't iounmap anything.
> Similar with pci_alloc_consistent.
> 
> I ask to consider reverting this part of the patch.

Done. Removed, thanks and sorry.

	Luis

> 
> Jens Maurer
> 
> _______________________________________________
> Prism54-devel mailing list
> Prism54-devel@prism54.org
> http://prism54.org/mailman/listinfo/prism54-devel