[Prism54-devel] Re: [PATCH] #1: cleanup, add reset debug message
Luis R. Rodriguez
mcgrof at ruslug.rutgers.edu
Wed Aug 11 00:18:09 UTC 2004
Denis,
this one seems fine to me although for netdev we'll need a patch
against linux kernel dirs (linux-2.6.8-rc4/drivers/net/prism54/) instead
of cvs tarball.
Jeff if you accept I'll apply to our CVS.
Luis
On Tue, Aug 10, 2004 at 06:23:15PM +0300, Denis Vlasenko wrote:
> Hi Luis,
>
> This is a mostly trivial patch on top of today's prism54 CVS.
>
> * Move assignment out of if()
> * Remove trailing space from printk
> * Eliminate not needed local 'u32 reg'
> * Add a comment about undoc bits
> * Add #define VEC_SIZE, use it as appropriate
> * Add a pair of printks to reset error code path (our current area of trouble)
> * Make printk text less confusing
>
> Please apply.
> --
> vda
--
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84 A34A 6ADD 4937 E20A 525E
More information about the Prism54-devel
mailing list