[Prism54-devel] handle mgmt timeouts by resetting hardware

Margit Schubert-While margitsw at t-online.de
Fri Aug 6 06:46:52 UTC 2004


More comments :
Dennis, are you trying to win the "Obfuscated C" prize ?
Have you got an aversion to white space ? :
eg.
    if (data==(unsigned long)NULL)
    if(modulation==DOT11_MOD_PBCC) return -ENOTSUPP;

Re: timer code.
You seem to have not taken into account PSM
(Power Saving Mode) and have ignored suspend/resume
totally.

Re: set rates.
prism54_set_rates :
Memory leak.
prism54_set_rates can return early without freeing memory from
mgt_get_request.
(Actually, the same applies to the current prism54_set_rate, which
  just shows that one should not blindly copy code - fix coming up)

Margit




More information about the Prism54-devel mailing list