[Prism54-devel] handle mgmt timeouts by resetting hardware

Denis Vlasenko vda at port.imtp.ilyichevsk.odessa.ua
Wed Aug 4 18:32:14 UTC 2004


> > Could you change your coding style ?
> > eg :
> > if(rate_enum<0) return rate_enum;

Done for prism54 files, not done for setrates.c
because it is targeted to wireless.c eventually and
I will do coding style changes to it according to Jean's
wishes.

> > Fine, I thought, nice way to check paths that don't usually get run.
> > I put in Denis's fixes and after the "Disabling IRQ" message,
> > the box was hard locked.
>
> Can you try splitted patches? I'll send them shortly

They are attached. Summary:

* Move an assignment out of if()
* Eliminate local u32 reg
* Add a comment about undoc bits
* Add #define VEC_SIZE and use it
* Make printk text less cofusing

* Some not needed NULL assignments removed
* Add some more printks to reset codepath
* mgt_commit_list(): tell which oid has failed

* Implement iwpriv set_rates

* Add hangup watchdog, empty one for now
* Do a reset if mgmt transaction timed out
* Prevent recursive resets and recursive mgmt timeouts
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.patch
Type: text/x-diff
Size: 4065 bytes
Desc: not available
Url : http://prism54.org/pipermail/prism54-devel/attachments/20040804/c2b93d4b/1-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2.patch
Type: text/x-diff
Size: 5064 bytes
Desc: not available
Url : http://prism54.org/pipermail/prism54-devel/attachments/20040804/c2b93d4b/2-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3.patch
Type: text/x-diff
Size: 8747 bytes
Desc: not available
Url : http://prism54.org/pipermail/prism54-devel/attachments/20040804/c2b93d4b/3-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4.patch
Type: text/x-diff
Size: 6670 bytes
Desc: not available
Url : http://prism54.org/pipermail/prism54-devel/attachments/20040804/c2b93d4b/4-0001.bin


More information about the Prism54-devel mailing list